Repository navigation
Conversation
Adds a help article for setting a category's default tax rate from the Expense defaults tab, and cross-links it from Workspace Rules and Merchant Rules. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
…nsify/workspaces
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new article, Set a default tax rate for a category, and wires it into two existing Rules articles (Workspace Merchant Rules and Workspace Rules) via cross-links. The changes are high quality overall: the new article is well-scoped to a single workflow, follows the required structure, and the edits to existing files are small, correct, and improve consistency. Assessment below is based only on the added/modified lines in the diff. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
|
||
| - To change the category or the tax rate, click the rule, update **Category** or **Tax**, then click **Save rule**. Changing the category moves the rate to the new category and removes the old rule. | ||
| - To remove a single rule, click the rule and then click **Delete rule**. | ||
| - To remove several rules at once, select their checkboxes and use the bulk delete action. |
There was a problem hiding this comment.
UI referencing violation: "use the bulk delete action" generalizes a UI element instead of naming it. Per HELPSITE_NAMING_CONVENTIONS.md (Core UI Referencing Rules / Prohibited Language), reference the exact UI control (e.g., the exact bold button/label the user clicks to delete the selected rules) rather than describing a generic "action".
| 1. In the navigation tabs (on the left on web, and at the bottom on mobile), click **Workspaces > [workspace name]**. | ||
| 2. Click **Rules**. | ||
| 3. In the **Merchant** section, click **Add merchant rule**. | ||
| 3. In the **Merchant** section, click **Add merchant rule**. If the **Rules** page shows tabs instead, select the **Expense defaults** tab, click **Add rule**, select **Apply expense defaults**, then select **Merchant**. |
There was a problem hiding this comment.
Step formatting violation: This single numbered step now embeds an entire conditional alternate flow with multiple chained actions ("select the Expense defaults tab, click Add rule, select Apply expense defaults, then select Merchant"). Per HELP_AUTHORING_GUIDELINES.md Section 5, steps must be sequential, clear, and single-action. Move the alternate-path instructions out of the numbered step into a separate conditional sentence/short sequence after the list so the primary flow stays scannable and deterministic.
|
|
||
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), click **Workspaces > [workspace name]**. | ||
| 2. Click **Rules**. | ||
| 3. If the **Rules** page shows tabs, select the **Expense defaults** tab. |
There was a problem hiding this comment.
Deterministic/step-formatting concern: Numbered step 3 is conditional ("If the Rules page shows tabs, select the Expense defaults tab."), and the procedure documents two divergent UI states (see also the alternate path at line 50). Per HELP_AUTHORING_GUIDELINES.md Section 5 and the Deterministic Writing Rule in HELPSITE_NAMING_CONVENTIONS.md, numbered steps should be non-conditional and single-action. Consider stating the applicable UI variant up front (or splitting the two flows) so the numbered sequence stays deterministic rather than embedding an "if" branch inside a step.
…for-a-category.md
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
…into claude-docsCategoryTaxDefaults Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://31f0f83a.helpdot.pages.dev ⚡️ Updated articles: |
Explanation of Change
Help site updates for the category tax defaults added in #99420.
That PR lets a Workspace Admin create an expense default that matches on a Category and sets a default Tax rate, alongside the existing merchant-matching rules. Nothing on the help site described this, so the new capability was undocumented.
Fixed Issues
$ Docs follow-up for #99420
What changed
New article —
docs/articles/new-expensify/workspaces/Set-a-default-tax-rate-for-a-category.mdCovers the one workflow end to end:
Category is "[category name]".Updated —
Workspace-Rules.mdUpdated —
Workspace-Merchant-Rules.mdRollout note for the reviewer
The tabbed Rules page is behind the
rulesRevampbeta. A live check of the current UI on web confirms the Rules page still shows Expenses, Merchant, and Agent rules sections with an Add merchant rule button — no tabs and no Add rule button. So the new steps use the same conditional phrasing already used inImport-Merchant-Rules.md("If the Rules page shows tabs…") rather than replacing the current instructions. Once the beta is fully rolled out, the conditional wording in all three articles can be dropped.Label and copy sources
All UI strings were taken from
src/languages/en.tson the merged PR: tab Expense defaults, button Add rule, chooser Apply expense defaults / What should this rule match on? / Merchant / Category, section headings Categories / Merchants / Merchant types, modals Turn on taxes first and Category rules apply going forward, empty state Taxes are not enabled / Enable taxes, and errors Please select a category / Please select a tax rate.Tests
Documentation only — no product code changed.
npm run spell-changedpasses on all three files (0 issues).QA Steps
Verify the rendered article at
/articles/new-expensify/workspaces/Set-a-default-tax-rate-for-a-categoryand confirm the cross-links from Workspace Rules and Merchant Rules resolve.PR Author Checklist
### Fixed Issuessection above@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.